Skip to content

Update cmake-format version for pre-commit and environments. - #995

Merged
rapids-bot[bot] merged 2 commits into
rapidsai:branch-22.06from
vyasr:feature/update_cmake_format
Apr 25, 2022
Merged

rapids-bot[bot] merged 2 commits into
rapidsai:branch-22.06from
vyasr:feature/update_cmake_format

Conversation

@vyasr

@vyasr vyasr commented Mar 15, 2022

Copy link
Copy Markdown
Contributor

Update to cmake-format 0.6.13.

@vyasr vyasr added 3 - Ready for review Ready for review by team CMake non-breaking Non-breaking change improvement Improvement / enhancement to an existing function labels Mar 15, 2022
@vyasr
vyasr requested a review from a team as a code owner March 15, 2022 22:55
@vyasr vyasr self-assigned this Mar 15, 2022
@vyasr

vyasr commented Mar 15, 2022

Copy link
Copy Markdown
Contributor Author

CC @robertmaynard

@github-actions github-actions Bot added conda and removed CMake labels Mar 15, 2022
@ajschmidt8

Copy link
Copy Markdown
Member

Just waiting on this PR before giving an ops-codeowner approval:

@vyasr vyasr added DO NOT MERGE Hold off on merging; see PR for details and removed 3 - Ready for review Ready for review by team labels Mar 16, 2022
@harrism

harrism commented Mar 23, 2022

Copy link
Copy Markdown
Member

Looks like this should move to 22.06 for code freeze.

@vyasr

vyasr commented Apr 19, 2022

Copy link
Copy Markdown
Contributor Author

This PR is currently blocked by rapidsai/integration#441.

@vyasr
vyasr force-pushed the feature/update_cmake_format branch from ca0b6c4 to 3c96227 Compare April 21, 2022 21:19
@github-actions github-actions Bot added CMake cpp Pertains to C++ code gpuCI Python Related to RMM Python API labels Apr 21, 2022
@vyasr
vyasr changed the base branch from branch-22.04 to branch-22.06 April 21, 2022 21:19
@vyasr
vyasr requested review from a team as code owners April 21, 2022 21:19
@vyasr
vyasr requested review from codereport and cwharris and removed request for a team April 21, 2022 21:19
@vyasr
vyasr removed request for a team, codereport and cwharris April 21, 2022 21:20
@vyasr vyasr removed Python Related to RMM Python API gpuCI cpp Pertains to C++ code labels Apr 21, 2022
@github-actions github-actions Bot removed the CMake label Apr 21, 2022
@ajschmidt8

Copy link
Copy Markdown
Member

rerun tests

@vyasr vyasr added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed DO NOT MERGE Hold off on merging; see PR for details labels Apr 25, 2022
@vyasr

vyasr commented Apr 25, 2022

Copy link
Copy Markdown
Contributor Author

@gpucibot merge

@rapids-bot
rapids-bot Bot merged commit ab4b81a into rapidsai:branch-22.06 Apr 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

5 - Ready to Merge Testing and reviews complete, ready to merge conda improvement Improvement / enhancement to an existing function non-breaking Non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants